Skip to content

ISO/IEC 19794-2:2005 Template IO #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
fatboab wants to merge 26 commits into
base: image-to-template-test
Choose a base branch
from
Open

ISO/IEC 19794-2:2005 Template IO #31

fatboab wants to merge 26 commits into from

Conversation

@fatboab
Copy link
Collaborator

@fatboab fatboab commented Nov 6, 2015

Import/Export methods for reading/writing ISO templates from SourceAFIS.

@fatboab
Copy link
Collaborator Author

fatboab commented Nov 6, 2015

Just realised we're not updating the template length in the file once we know it...

@fatboab
Copy link
Collaborator Author

fatboab commented Nov 6, 2015

Good to be merged now...

@andrew-farries
Copy link
Contributor

andrew-farries commented Nov 6, 2015

The test TemplateIO_ISO19794_2_2005 fails on my machine with: Expected 6 Was 500. originalDpi's are different

It segfaults on @olane 's machine.

I'm on cygwin on Windows. @olane is on a mac.

@cjheppell
Copy link
Contributor

cjheppell commented Nov 6, 2015

FWIW, running this through gdb on OS X points to this on failure:

Program received signal SIGSEGV, Segmentation fault.
[..] in TemplateIO_ISO19794_2_2005_Export [..] at Templates/TemplateIO.c:117
117         int16_t x = minutia->position.x;

Pointing to line 117 in TemplateIO.c as a possible issue?

@fatboab
Copy link
Collaborator Author

fatboab commented Nov 8, 2015

Oh FFS! Turns out that on cygwin at least, the Unity TEST_SETUP stuff wasn't being called, so the template that was being written to disk was bogus. It's now failing on the Import portion of the test...

@fatboab
Copy link
Collaborator Author

fatboab commented Nov 11, 2015

@andrew-farries @cjheppell so @david-connell and I have fixed it to run under cygwin and fixed the resulting memory leaks. With the memory leak stuff that @fffej did, we hope this means this is now good to be merged.

fffej
fffej reviewed Nov 16, 2015
View reviewed changes
Sources/Templates/Template.c
Copy link
Collaborator

@fffej fffej Nov 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we going to use const consistently? I'd have thought both should be const in this situation?

Copy link
Collaborator Author

@fatboab fatboab Nov 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea, we need to decide on a few things like that and then apply them to all the code in another branch I think...

@andrew-farries andrew-farries removed their assignment Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@fatboab @andrew-farries @cjheppell @fffej @david-connell